Add metrics for btrfs commit statistics #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maarten van den Berg <[email protected]>
maartenberg
force-pushed
the
maartenberg/expose-btrfs-commit-stats
branch
from
224d6e9 to
cc1aa3c
Compare
| value: float64(s.CommitStats.Commits), | ||
| }, | ||
| { | ||
| name: "last_commit_seconds", |
There was a problem hiding this comment.
Wondering if we even need last/max, given we can calculate them from total
There was a problem hiding this comment.
According to the docs the reported value for the max can be (re)set by writing into the file the statistics are read from (commit_stats), so if that is used I think the value can't be calculated anymore.
|
Ping @SuperQ @discordianfish: could you still take a look at this / is there anything else I should do? |
SuperQ
approved these changes
Jul 14, 2024
v-zhuravlev
pushed a commit
to grafana/node_exporter
that referenced
this pull request
Nov 1, 2024
Signed-off-by: Maarten van den Berg <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add four metrics to the btrfs collector to expose statistics on the commits to the filesystem:
node_btrfs_commits_total,node_btrfs_last_commit_seconds,node_btrfs_max_commit_seconds, andnode_btrfs_commit_seconds_total.These values were added to the procfs library in prometheus/procfs#580, but not exposed as a metric yet.
Fixes #2734.